2023-07-29 20:12 AEST by Arthur Barrett - Trying to commit to a server that has the incorrect repository type=3 (when no 
remote proxy specified) gives the error:
Sync protocol not available.  Cannot start proxy

There are 3 problems with this error, it's unclear:
1) to the user if this is a client or server error
2) what is actually wrong or why it's looking for sync protocol
3) how the administrator should fix it

error should be caught earlier during repo add:
Server repository config error (type=3 but no remote server)

change the actual message to:
Server repository type=3 and Sync protocol not available.  Cannot start proxy


This change is only really needed in 2.8.02 because we don't support repository 
replication on 2.8.01

2023-07-29 20:31 AEST by Arthur Barrett - The new message looks like:
cvs server: Server repository type=3 and Sync protocol not available.  Cannot 
start proxy


The prefix seems to come from the fact that 'error()' is passed a non-zero code, 
ie: error.

non-error messages don't get the 'cvs server:' prefix I guess.

2023-07-30 13:54 AEST by Arthur Barrett - It's a licensing problem:



debiancvs:/home/tmh/cvsnt# grep -C 5 "no feature" /tmp/cvs-server-20210.log

01:56:18: S -> EnumerateProtocols: /usr/local/lib/cvsnt/protocols

01:56:18: S -> Loading protocol pserver as pserver.la

01:56:18: S -> get_interface(pserver) - shouldn't this initialise verify_only (0)?

01:56:18: S -> Library reference count set to 1.

01:56:18: S -> Loading protocol sync as sync.la

01:56:18: S -> Not loading sync (DD) - no feature license [ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ]

01:56:18: S -> Loading protocol gserver as gserver.la

01:56:18: S -> Library reference count set to 1.

01:56:18: S -> Loading protocol ext as ext.la

01:56:18: S -> Library reference count set to 1.

01:56:18: S -> Loading protocol enum as enum.la

--

01:56:50: S -> server: read line status = 0 cmd = 'ci'.

01:56:50: S -> server perform verb `ci' command `'.

01:56:50: S -> proxy_main started

01:56:50: S -> proxy main -Construct a root as if we were the client- phys repos=
(/usr/local/cvsrep/cvs,/usr/local/proxy,/cvs).

01:56:50: S -> Loading protocol sync as sync.la

01:56:50: S -> Not loading sync (DD) - no feature license [ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ-ZZ]

01:56:50: S -> nonpacketizing_buffer_output

01:56:50: S -> nonpacketizing_buffer_output: result: 0

01:56:50: S -> cvs server: Server repository type=3 and Sync protocol not available.  Cannot start proxy



01:56:50: S -> run postsync proc server









So there are 2 issues

1) fix the license

2) need to display the error message when the sync protocol load fails (in server.cpp)



	current_parsed_root->optional_2 = xstrdup(CVS_Username);

	current_parsed_root->optional_3 = xstrdup("proxy");

	current_parsed_root->remote_repository = xstrdup(oldroot->remote_repository);

	current_parsed_root->proxy_repository_root = xstrdup(oldroot->proxy_repository_root);



	// we would normally check that the sync protocol is actually enabled

	// but the fact you have a repository type 2 or 3, then it implies the sync protocol

	CProtocolLibrary lib;

	client_protocol = lib.LoadProtocol("sync",hostname,server_features);

	if(!client_protocol)

	{

		// current_parsed_root->type == RootTypeProxyWrite:, ie /etc/cvsnt/PServer "Repository%dType"=3

		error(0, 0, "Server repository type=3 and Sync protocol not available.  Cannot start proxy");

		exitstatus = 1;

2023-09-17 14:46 AEST by Arthur Barrett - This is a 2.8.02 licensing problem, does not affect 2.8.01?