2022-05-06 16:49 AEST by Arthur Barrett - in update.cpp in the function update_fileproc ()

the variable retval; is not always initialised before use:

    /* only try to join if things have gone well thus far */
    if (retval == 0 && join_rev1)
		join_file (finfo, vers);


found during debug of CVS Suite 2010:

Test: update -F should not alter Entries or sandbox at 07:24:46 [ 442.953 s]
  ressurect add_test.txt
  update -F temp-file, to revision 1.5 (maastrict.txt)
  update -F temp-file, to revision 1.2 (dead)
  update -F temp-file, to revision 1.3 (add_test.cpp)
  update -F temp-file, to revision 1.4 (dead)

2022-05-06 18:45 AEST by Arthur Barrett - trying to fix this gave me a test error:

      cvs update: add_test.txt is no longer in the repository

 file_delete(current_tree+'/add_test_temp.txt')
 file_not_exists(current_tree+'/add_test_temp.txt')
 print '  update -F temp-file, to revision 1.2 (dead)'
 cvs_fail('update -r 1.2 -F "'+current_tree+'/add_test_temp.txt" add_test.txt')



so I've commented it out:
	//retval = 0;


next time maybe I should try:
	retval = -1;

2022-05-07 06:50 AEST by Arthur Barrett - On a subsequent test, I got a different failure (in the same general area):
Test: update -F should not alter Entries or sandbox at 21:33:23 [ 390.292 s]
  ressurect add_test.txt
File d:\cvsbin\release builder\cvsnt\testcvs/tree_0/testcvs/CVS/Entries Should b
e identical to File d:\cvsbin\release builder\cvsnt\testcvs/test_data/add_test_e
ntries.txt. Terminating.
Line /test1.txt/1.110/??? ??? ?? ??:??:?? 20??//
 Should be identical to Line /test1.txt/1.109/Fri May  6 20:33:22 2022//
.
Error matching at line 11 character 14: 1 <> 0.