2014-03-31 16:05 AEST by Arthur Barrett - Customer supplied crash dump that occurred with 'cvs history' using date

In the SmartCVS GUI, I do the following; Highlight all files in a checked out project. Go to menu named 
‘Query’. Choose option named ‘Transactions…’. Ask for 48 Months. It says ‘Refreshing…’ for some time 
and eventually fails”

2014-03-31 16:09 AEST by Arthur Barrett - stack trace:

wmain()
main()
preload()
run_preload()
server()
serve_history()
do_cvs_command()
server_main()
history()
read_hrecs()
select_hrec()
RCS_datecmp()
date_from_time_t()


It fails with an access violation on this:
    (void) sprintf (date, DATEFORM,
		    ftm->tm_year + (ftm->tm_year < 100 ? 0 : 1900),
		    ftm->tm_mon + 1, ftm->tm_mday, ftm->tm_hour,
		    ftm->tm_min, ftm->tm_sec);


Which indicates that either the call to localtime() failed, or that the junk in ftm is way bigger than the 'date' 
string:

   ftm = localtime (&unixtime);

This is intended behaviour (that sprint should crash due to unexpected data), but the question is why the 
unexpected data?  Is it some bug in 'history' date processing, or is it bad data in the RCS file?

2014-03-31 17:50 AEST by Arthur Barrett - testing against source forge gives a command trace like this:

BEGIN AUTH REQUEST
/cvsroot/cvsgui
anonymous
@encodedPassword@
END AUTH REQUEST
Valid-responses E M MT Updated Checked-in ok error Clear-static-directory Valid-requests Merged 
Removed Copy-file Mod-time Mode Kop
 Template Set-static-directory Module-expansion Clear-sticky Set-sticky New-entry
valid-requests
UseUnchanged
Root /cvsroot/cvsgui
Argument --
Argument cvsgui
rlog
BEGIN AUTH REQUEST
/cvsroot/cvsgui
anonymous
@encodedPassword@
END AUTH REQUEST
Valid-responses E M MT Updated Checked-in ok error Clear-static-directory Valid-requests Merged 
Removed Copy-file Mod-time Mode Kop
 Template Set-static-directory Module-expansion Clear-sticky Set-sticky New-entry
valid-requests
UseUnchanged
Root /cvsroot/cvsgui
Argument -a
Argument -D
Argument 2012-11-10 17:35 +0000
Argument -f
Argument cvsgui/
Argument -x
Argument AMR
Argument -z
Argument +0000
Argument --
history


The result is 'no transactions found' message dialog box with an OK button.

2014-03-31 19:16 AEST by Arthur Barrett - I can test 'cvsnt' too - the 'transactions' window will now show if the server gives any type of error 
message (e.g.: due to a corrupt RCS file).

BEGIN AUTH REQUEST
/cvsrepo
abarrett
@encodedPassword@
END AUTH REQUEST
Valid-responses E M MT Updated Checked-in ok error Clear-static-directory Valid-requests Merged 
Removed Copy-file Mod-time Mode Kopt
 Template Set-static-directory Module-expansion Clear-sticky Set-sticky New-entry
valid-requests
UseUnchanged
Root /cvsrepo
client-version SmartCVS 7.1.7.1
Argument --
Argument cvsnt
rlog
BEGIN AUTH REQUEST
/cvsrepo
abarrett
@encodedPassword@
END AUTH REQUEST
Valid-responses E M MT Updated Checked-in ok error Clear-static-directory Valid-requests Merged 
Removed Copy-file Mod-time Mode Kopt
 Template Set-static-directory Module-expansion Clear-sticky Set-sticky New-entry
valid-requests
UseUnchanged
Root /cvsrepo
client-version SmartCVS 7.1.7.1
Argument -a
Argument -D
Argument 2012-05-01 19:28 +0000
Argument -f
Argument cvsnt/
Argument -x
Argument AMR
Argument -z
Argument +0000
Argument --
history