|
Actions:
|
2008-09-05 12:47 AEST by Arthur Barrett - CVSNT protocol should support something for Audit.
It was specifically raised during a dev team meeting in Manchester that we may
want to release a graphical client specifically for showing audit graphs, for
example an iPhone app.
Currently there is no way of transferring this information in the protocol. So
ideally in CVS Suite 2008 and 2.5.04 this should be available somehow in the
protocol but not necessarily exploited in a command or documented (or even very
usable). |
|
|
2008-09-05 14:52 AEST by Arthur Barrett - Created an attachment (id=1338)
Proposed first half patch to 2.5.03
This patch hacks in a -a audit-report-name and -u user-name parameters to the
rls protocol and passes those parameters plus the whole argc/argv to a new
method in the trigger.
This does not include any sensible processing by the audit trigger itself.
The idea is that there are several "hardcoded" reports in the audit trigger
that take the module/filename(s) and possibly also a username to produce
reports. The finaly reports would be sent down the protocol in plain text like
the RLS output (or possibly in XML).
This patch just hooks in the parameters.
|
|
|
2008-09-05 14:53 AEST by Arthur Barrett - Committed to 2.5.03:
Checking in cvstools/trigger_interface.h;
/cvs/cvsnt/cvstools/trigger_interface.h,v <-- trigger_interface.h
new revision: 1.1.2.8.4.6; previous revision: 1.1.2.8.4.5
done
Checking in src/cvs.h;
/cvs/cvsnt/src/cvs.h,v <-- cvs.h
new revision: 1.93.2.208.6.15; previous revision: 1.93.2.208.6.14
done
Checking in src/ls.cpp;
/cvs/cvsnt/src/ls.c,v <-- ls.cpp
new revision: 1.14.2.33.6.2; previous revision: 1.14.2.33.6.1
done
Checking in src/server.cpp;
/cvs/cvsnt/src/server.c,v <-- server.cpp
new revision: 1.106.2.210.6.62; previous revision: 1.106.2.210.6.61
done
Checking in src/server.h;
/cvs/cvsnt/src/server.h,v <-- server.h
new revision: 1.17.2.25.6.3; previous revision: 1.17.2.25.6.2
done
Checking in triggers/audit_trigger.cpp;
/cvs/cvsnt/triggers/audit_trigger.cpp,v <-- audit_trigger.cpp
new revision: 1.1.2.33.4.40; previous revision: 1.1.2.33.4.39
done
Checking in triggers/checkout_trigger.cpp;
/cvs/cvsnt/triggers/checkout_trigger.cpp,v <-- checkout_trigger.cpp
new revision: 1.1.2.16.4.9; previous revision: 1.1.2.16.4.8
done
Checking in triggers/email_trigger.cpp;
/cvs/cvsnt/triggers/email_trigger.cpp,v <-- email_trigger.cpp
new revision: 1.1.2.26.4.7; previous revision: 1.1.2.26.4.6
done
Checking in triggers/info_trigger.cpp;
/cvs/cvsnt/triggers/info_trigger.cpp,v <-- info_trigger.cpp
new revision: 1.1.2.82.4.15; previous revision: 1.1.2.82.4.14
done
Checking in triggers/script_trigger.cpp;
/cvs/cvsnt/triggers/script_trigger.cpp,v <-- script_trigger.cpp
new revision: 1.1.2.18.4.10; previous revision: 1.1.2.18.4.9
done
|
|
|
2008-09-05 16:15 AEST by Arthur Barrett - Created an attachment (id=1342)
Patch for bug/make triggers
Checking in bug_trigger/bug_trigger.cpp;
/cvs/triggers/bug_trigger/bug_trigger.cpp,v <-- bug_trigger.cpp
new revision: 1.16.2.61; previous revision: 1.16.2.60
done
Checking in make_trigger/make_trigger.cpp;
/cvs/triggers/make_trigger/make_trigger.cpp,v <-- make_trigger.cpp
new revision: 1.13.2.12; previous revision: 1.13.2.11
done |
|
|
2008-09-06 00:56 AEST by Glen Starrett - Suggestion on this one: If the Audit could have a lookup somewhere (table,
file, whatever) that would have a report name and a query then the protocol
could grab the name and run the query, returning the results as XML. |
|
|
2008-09-10 09:07 AEST by Arthur Barrett - Created an attachment (id=1344)
Patch for audit report lookup table as per suggestion
Two simple reports to begin with:
* a report to list the available reports
* the report "Users by lines of code changed" from the eBook
Note: the "cvs rls -a" command does not yet actually run any reports.
Note2: the idea is that a single %s in a report would be replaced with the -u
parameter from the client (usually used for delimiting a report by
user/author).
|
|
|
2008-09-10 09:08 AEST by Arthur Barrett - Committed patch for report lookup table:
cvs commit: Examining .
Checking in create_tables_db2.sql;
/cvs/cvsnt/triggers/sql/create_tables_db2.sql,v <-- create_tables_db2.sql
new revision: 1.1.2.2.4.4; previous revision: 1.1.2.2.4.3
done
Checking in create_tables_mssql.sql;
/cvs/cvsnt/triggers/sql/create_tables_mssql.sql,v <-- create_tables_mssql.sql
new revision: 1.1.2.2.4.4; previous revision: 1.1.2.2.4.3
done
Checking in create_tables_mysql.sql;
/cvs/cvsnt/triggers/sql/create_tables_mysql.sql,v <-- create_tables_mysql.sql
new revision: 1.1.2.4.4.4; previous revision: 1.1.2.4.4.3
done
Checking in create_tables_oracle.sql;
/cvs/cvsnt/triggers/sql/create_tables_oracle.sql,v <-- create_tables_oracle.sq
l
new revision: 1.3.2.5; previous revision: 1.3.2.4
done
Checking in create_tables_pgsql.sql;
/cvs/cvsnt/triggers/sql/create_tables_pgsql.sql,v <-- create_tables_pgsql.sql
new revision: 1.1.2.2.4.4; previous revision: 1.1.2.2.4.3
done
Checking in create_tables_sqlite.sql;
/cvs/cvsnt/triggers/sql/create_tables_sqlite.sql,v <-- create_tables_sqlite.sq
l
new revision: 1.1.2.3.4.6; previous revision: 1.1.2.3.4.5
done
Checking in upgrade_3_db2.sql;
/cvs/cvsnt/triggers/sql/upgrade_3_db2.sql,v <-- upgrade_3_db2.sql
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in upgrade_3_mssql.sql;
/cvs/cvsnt/triggers/sql/upgrade_3_mssql.sql,v <-- upgrade_3_mssql.sql
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in upgrade_3_mysql.sql;
/cvs/cvsnt/triggers/sql/upgrade_3_mysql.sql,v <-- upgrade_3_mysql.sql
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in upgrade_3_oracle.sql;
/cvs/cvsnt/triggers/sql/upgrade_3_oracle.sql,v <-- upgrade_3_oracle.sql
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in upgrade_3_pgsql.sql;
/cvs/cvsnt/triggers/sql/upgrade_3_pgsql.sql,v <-- upgrade_3_pgsql.sql
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in upgrade_3_sqlite.sql;
/cvs/cvsnt/triggers/sql/upgrade_3_sqlite.sql,v <-- upgrade_3_sqlite.sql
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
|
|
|
2008-09-11 09:28 AEST by Arthur Barrett - OK - so I've tested that the 'ls' trigger is being called with the correct
params:
cvs -d :sspi:localhost:/c-repo rls -a test
gives this result:
13:21:59: S -> run ls proc server
13:21:59: S -> run_trigger()
13:21:59: S -> Call pre-loaded 'auditor.dll'
13:21:59: S -> Audit lsaudit "test" user "*noone*" argc=1
13:21:59: S -> ls_proc()
13:21:59: S -> Call pre-loaded 'auditor.dll' returned 0, total ret 0
13:21:59: S -> Call pre-loaded 'bugzilla.dll'
13:21:59: S -> Bug Trigger lsbugs "test" user "*noone*" argc=1
13:21:59: S -> ls_proc()
13:21:59: S -> Call pre-loaded 'bugzilla.dll' returned 0, total ret 0
|
|
|
2008-11-07 13:27 AEST by Arthur Barrett - Still incomplete - no way to trigger the reports yet from the client in 2.5.03,3226 |