2008-05-09 11:52 AEST by Arthur Barrett - Customer reports: Suse 9: cvs server hangs if client ctrl-c during commit

This should not be possible on linux (It's a known problem with CVSNT Server on 
windows that this can happen in 'some cases' - but not regularly).

On Linux and Unix the server OS should close a port as soon as a client drops 
it causing any program using that port to return to user-mode.

The customer is adamant this is easy to reproduce, so we need to test it on 
SuSE linux before releaseing CVS Suite Server 2088 in case it is a problem 
specific to that platform that we need to address before stable.

2009-05-01 10:24 AEST by Arthur Barrett - We've had no new reports of this since the upgrade, probably adding the setsockopt() stuff to 
cvsnt/protocols/common.cpp has fixed this:

#ifndef CVS95
	// I'd like to set SO_RCVTIMEO and SO_SNDTIMEO here, to around 120 seconds!
	// the microsoft msdn page says it is "not supported" but is supported in the MS socket(2) 
implementation...
	// on windows requires sockets 2
	int wrwait=120*1000;
	int wswait=120*1000;
	char bufferw[MAX_PATH]="\0";
	if(!CGlobalSettings::GetGlobalValue("cvsnt","PServer","RCVTIMEO",bufferw,sizeof(bufferw)))
		wrwait = atoi(bufferw)*1000;
	if(!CGlobalSettings::GetGlobalValue("cvsnt","PServer","SNDTIMEO",bufferw,sizeof(bufferw)))
		wswait = atoi(bufferw);

	setsockopt(sock,IPPROTO_TCP,SO_RCVTIMEO,(const char *)&wrwait,sizeof(wswait));
	setsockopt(sock,IPPROTO_TCP,SO_SNDTIMEO,(const char *)&wswait,sizeof(wswait));
#endif

	CServerIo::trace(99,"tcp_connect_bind(%s:%d) ok - assigned tcp_fd to 
sock",PATCH_NULL(servername),remote_port);

2009-05-01 11:14 AEST by Arthur Barrett - Note: this change only affects client/server protocols and specifically NOT SSH which behaves as local and 
uses a pipe to the incoming connection (served by the sshd), ie: stdio_buffer_input and stdio_buffer_output.